[Intel-gfx] [PATCH 1/7] drm/i915: unify first-stage engine struct setup

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Jul 14 09:19:16 UTC 2016


On 13/07/16 17:01, Chris Wilson wrote:
> On Wed, Jul 13, 2016 at 04:03:35PM +0100, Tvrtko Ursulin wrote:
>> From: Dave Gordon <david.s.gordon at intel.com>
>>
>> intel_lrc.c has a table of "logical rings" (meaning engines), while
>> intel_ringbuffer.c has separately open-coded initialisation for each
>> engine. We can deduplicate this somewhat by using the same first-stage
>> engine-setup function for both modes.
>>
>> So here we expose the function that transfers information from the
>> static table of (all) known engines to the dev_priv->engine array of
>> engines available on this device (adjusting the names along the way)
>> and then embed calls to it in both the LRC and the legacy-mode setup.
>>
>> Signed-off-by: Dave Gordon <david.s.gordon at intel.com>
>
> LGTM, I didn't see anything that would impede applying this series,
> so
> Reviewed-by: Chris Wilson <chris-wilson.co.uk>
>
> (Goes off to double check...)

R-b for the series or 1/7 ?

Regards,

Tvrtko



More information about the Intel-gfx mailing list