[Intel-gfx] [PATCH] drm/i915: Move hangcheck reset from out of the engines into the GPU reset

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 14 14:11:52 UTC 2016


On Thu, Jul 14, 2016 at 04:59:56PM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Let's not reset the hangcheck as a side-effect of initialising the
> > engine, but as part of our GPU reset.
> >
> 
> I think TDR will need both the init and the reset.

It doesn't. This state is the purely global state for hangcheck. There's
probably a better spot, such as hangcheck expiration, but at the moment
this is better. TDR will be keeping its own data structures and should
not stop the global hangcheck from stepping in and saying enough is
enough.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list