[Intel-gfx] [PATCH 1/2] drm/i915/fbdev: Drain the suspend worker on retiring

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 14 14:55:49 UTC 2016


On Thu, Jul 14, 2016 at 04:45:52PM +0200, Daniel Vetter wrote:
> On Thu, Jul 14, 2016 at 01:47:49PM +0300, Mika Kuoppala wrote:
> > Chris Wilson <chris at chris-wilson.co.uk> writes:
> > 
> > > Since the suspend_work can arm itself if the console_lock() is currently
> > > held elsewhere, simply calling flush_work() doesn't guarantee that the
> > > work is idle upon return. To do so requires using cancel_work_sync().
> > >
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > > Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> > 
> > Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>
> 
> Cc: stable at vger.kernel.org I presume? Checking for this should be part of
> the review ...

No known bug - unlikely since ~nobody unloads the module.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list