[Intel-gfx] [PATCH 1/2] drm/i915: add missing condition for committing planes on crtc

[Maarten Lankhorst]

Op 15-07-16 om 12:51 schreef Lionel Landwerlin:
> The i915 driver checks for color management properties changes as part
> of a plane update. Therefore a color management update must imply a
> plane update, otherwise we never update the transformation matrixes
> and degamma/gamma LUTs.
>
> v2: add comment about moving the commit of color management registers
>     to an async worker
>
> v3: Commit color management register right after vblank
>
> v4: Move back color management commit condition together with planes
>     commit
>
> v5: Trigger color management commit through the planes commit (Daniel)
>
> v6: Make plane change update more readable
>
> igt-testcase: kms_pipe_color --run-subtests ctm-*
> Fixes: 20a34e78f0d7 (drm/i915: Update color management during vblank evasion.)
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 04452cf..3074c56 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11997,6 +11997,12 @@ static int intel_crtc_atomic_check(struct drm_crtc *crtc,
>  		ret = intel_color_check(crtc, crtc_state);
>  		if (ret)
>  			return ret;
> +
> +		/*
> +		 * Changing color management on Intel hardware is
> +		 * handled as part of planes update.
> +		 */
> +		crtc_state->planes_changed = true;
>  	}
>  
>  	ret = 0;

Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>