[Intel-gfx] [PATCH i-g-t v2 03/15] kms_psr_sink_crc: Use for_each_pipe_with_valid_output to find a valid config.

Ander Conselvan De Oliveira conselvan2 at gmail.com
Tue Jul 19 13:58:45 UTC 2016


On Fri, 2016-07-15 at 14:15 +0300, Ander Conselvan De Oliveira wrote:
> On Wed, 2016-07-06 at 11:55 +0200, Maarten Lankhorst wrote:
> > 
> > This is the only time PIPE_ANY was used to mean something other than
> > unassign this output from a pipe. Without this PIPE_ANY can be aliased
> > to PIPE_NONE.
> > 
> > Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2 at gmail.com>

Actually, kms_sink_crc_basic needs the same treatment.

Ander

> 
> > 
> > ---
> >  tests/kms_psr_sink_crc.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> > index b18e426303e3..d7bce3bb7855 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -103,15 +103,16 @@ static void setup_output(data_t *data)
> >  {
> >  	igt_display_t *display = &data->display;
> >  	igt_output_t *output;
> > +	enum pipe pipe;
> >  
> > -	for_each_connected_output(display, output) {
> > +	for_each_pipe_with_valid_output(display, pipe, output) {
> >  		drmModeConnectorPtr c = output->config.connector;
> >  
> >  		if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
> >  		    c->connection != DRM_MODE_CONNECTED)
> >  			continue;
> >  
> > -		igt_output_set_pipe(output, PIPE_ANY);
> > +		igt_output_set_pipe(output, pipe);
> >  		data->crtc_id = output->config.crtc->crtc_id;
> >  		data->output = output;
> >  		data->mode = igt_output_get_mode(output);


More information about the Intel-gfx mailing list