[Intel-gfx] [PATCH v2 03/15] drm: Add support for optional per-plane rotation property

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Jul 25 07:08:32 UTC 2016


On pe, 2016-07-22 at 16:43 +0300, ville.syrjala at linux.intel.com wrote:
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 986de180e6c2..9e20a52ece7c 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -5801,6 +5801,39 @@ struct drm_property *drm_mode_create_rotation_property(struct drm_device *dev,
>  }
>  EXPORT_SYMBOL(drm_mode_create_rotation_property);
>  
> +int drm_plane_create_rotation_property(struct drm_plane *plane,
> +				       unsigned int rotation,
> +				       unsigned int supported_rotations)
> +{
> +	static const struct drm_prop_enum_list props[] = {
> +		{ DRM_ROTATE_0,   "rotate-0" },
> +		{ DRM_ROTATE_90,  "rotate-90" },
> +		{ DRM_ROTATE_180, "rotate-180" },
> +		{ DRM_ROTATE_270, "rotate-270" },
> +		{ DRM_REFLECT_X,  "reflect-x" },
> +		{ DRM_REFLECT_Y,  "reflect-y" },

I sent a series for converting the DRM_ROTATE_? defines into BIT()
variants, so __builtin_ffs(DRM_ROTATE_0) - 1 etc. would end up used
here depending on which gets merged first.

Also,

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list