[Intel-gfx] [PATCH 17/31] drm/i915: Remove obsolete engine->gpu_caches_dirty

[Chris Wilson]

On Mon, Jul 25, 2016 at 12:14:44PM +0300, Joonas Lahtinen wrote:
> On ma, 2016-07-25 at 08:44 +0100, Chris Wilson wrote:
> > Space for flushing the GPU cache prior to completing the request is
> > preallocated and so cannot fail.
> 
> Patch title and commit message have some disconnect. Could you explain
> in a bit more detail what made gpu_caches_dirty obsolete?

Introduction of requests. gpu_caches_dirty tracked the GPU cache state
for the outstanding_lazy_seqno, long obsolete, since we only submit
complete requests. (Previously we could cancel the breadcrumb due to an
interrupt without having flushed the caches and so before the next batch
we had to emit a cache flush.)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre