[Intel-gfx] [CI 3/5] drm/i915: Avoid using intel_engine_cs *ring for GPU error capture

Dave Gordon david.s.gordon at intel.com
Wed Jul 27 14:59:55 UTC 2016


On 27/07/16 09:07, Chris Wilson wrote:
> Inside the error capture itself, we refer to not only the hardware
> engine, its ringbuffer but also the capture state. Finding clear names
> for each whilst avoiding mixing ring/intel_engine_cs is tricky. As a
> compromise we keep using ering for the error capture.
>
> v2: Use 'ee' locals for struct drm_i915_error_engine

That's better than 'ering', and I don't think it that much matters that 
it's not very descriptive, as it can be just a local convention within 
the error-capture code.

.Dave.

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Link: http://patchwork.freedesktop.org/patch/msgid/1469432687-22756-8-git-send-email-chris@chris-wilson.co.uk
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h       |   8 +-
>  drivers/gpu/drm/i915/i915_gpu_error.c | 403 +++++++++++++++++-----------------
>  2 files changed, 208 insertions(+), 203 deletions(-)



More information about the Intel-gfx mailing list