[Intel-gfx] [PATCH 16/22] drm/i915: Make fb_tracking.lock a spinlock

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Thu Jul 28 10:19:06 UTC 2016


On ke, 2016-07-27 at 12:14 +0100, Chris Wilson wrote:
> 
>  	/* Delay flushing when rings are still busy.*/
> -	mutex_lock(&dev_priv->fb_tracking.lock);
> +	spin_lock(&dev_priv->fb_tracking.lock);
>  	frontbuffer_bits &= ~dev_priv->fb_tracking.busy_bits;
> -	mutex_unlock(&dev_priv->fb_tracking.lock);
> +	spin_unlock(&dev_priv->fb_tracking.lock);
>  
> -	if (!frontbuffer_bits)
> +	if (frontbuffer_bits == 0)

Ugh, there are two styles within same patch already, maybe go with !
here too. That unified;

Reviewed-by: Joonas Lahtien <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list