[Intel-gfx] [PATCH] drm/i915: remove redundant fbc warnings

Zanoni, Paulo R paulo.r.zanoni at intel.com
Thu Jul 28 18:29:58 UTC 2016


Em Ter, 2016-07-05 às 10:28 +0100, Matthew Auld escreveu:
> The fbc enabled/active sanity checks are already done in
> __intel_fbc_disable so no need to do them again.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_fbc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c
> b/drivers/gpu/drm/i915/intel_fbc.c
> index 067b6f5..e77104d 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -1163,11 +1163,8 @@ void intel_fbc_disable(struct intel_crtc
> *crtc)
>  		return;
>  
>  	mutex_lock(&fbc->lock);
> -	if (fbc->crtc == crtc) {
> -		WARN_ON(!fbc->enabled);
> -		WARN_ON(fbc->active);
> +	if (fbc->crtc == crtc)
>  		__intel_fbc_disable(dev_priv);
> -	}
>  	mutex_unlock(&fbc->lock);
>  
>  	cancel_work_sync(&fbc->work.work);


More information about the Intel-gfx mailing list