[Intel-gfx] [PATCH 09/12] drm/i915: Remove useless rate_to_index() usage

Daniel Vetter daniel at ffwll.ch
Fri Jul 29 09:33:14 UTC 2016


On Thu, Jul 28, 2016 at 05:50:45PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> No need to iterate the rates array in intel_dp_max_link_rate(). We know
> the max rate will be the last entry, and we already know the size.
> 
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> Cc: Jim Bride <jim.bride at linux.intel.com>
> Cc: Manasi D Navare <manasi.d.navare at intel.com>
> Cc: Durgadoss R <durgadoss.r at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Yeah, that's some rather convoluted logic.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index d1dd351682d2..40cae6202160 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1447,7 +1447,7 @@ intel_dp_max_link_rate(struct intel_dp *intel_dp)
>  	if (WARN_ON(len <= 0))
>  		return 162000;
>  
> -	return rates[rate_to_index(0, rates) - 1];
> +	return rates[len - 1];
>  }
>  
>  int intel_dp_rate_select(struct intel_dp *intel_dp, int rate)
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list