[Intel-gfx] [PATCH v4 1/1] drm/i915: Update GEN6_PMINTRMSK setup with GuC enabled

[Chris Wilson]

On Tue, May 31, 2016 at 04:18:34PM -0700, Matt Roper wrote:
> On Tue, May 31, 2016 at 09:51:53AM +0100, Chris Wilson wrote:
> > On Tue, May 31, 2016 at 01:58:27PM +0530, Sagar Arun Kamble wrote:
> > > On Loading, GuC sets PM interrupts routing (bit 31) and clears ARAT
> > > expired interrupt (bit 9). Host turbo also updates this register
> > > in RPS flows. This patch ensures bit 31 and bit 9 setup by GuC persists.
> > > ARAT timer interrupt is needed in GuC for various features. It also
> > > facilitates halting GuC and hence achieving RC6. PM interrupt routing
> > > will not impact RPS interrupt reception by host as GuC will redirect
> > > them.
> > > This patch fixes igt test pm_rc6_residency that was failing with guc
> > > load/submission enabled. Tested with SKL GuC v6.1 and BXT GuC v5.1 and v8.7.
> > > 
> > > v2: i915_irq/i915_pm decoupling from intel_guc. (ChrisW)
> > > 
> > > v3: restructuring the mask update and rebase w.r.t Ville's patch. (ChrisW)
> > > 
> > > v4: Updating the pm_intr_keep during direct_interrupts_to_guc. (Sagar)
> > > 
> > > Cc: Chris Harris <chris.harris at intel.com>
> > > Cc: Zhe Wang <zhe1.wang at intel.com>
> > > Cc: Deepak S <deepak.s at intel.com>
> > > Cc: Satyanantha, Rama Gopal M <rama.gopal.m.satyanantha at intel.com>
> > > Cc: Akash Goel <akash.goel at intel.com>
> > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> > 
> > I can understand what you mean by this patch, perfect!
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> > -Chris
> 
> Testcase: igt/pm_rc6_residency
> Tested-by: Matt Roper <matthew.d.roper at intel.com>
> 
> Merged to dinq.  Thanks for the patch and review.

This was only the second patch, it also wants the first patch to always
use gen6_sanitize_pm_mask otherwise we loose the interrupt bypass from
gen6_rps_idle(). That should have been caught by the testcase...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre