[Intel-gfx] [PATCH v3 24/33] drm/i915: Skip idling an idle engine
Chris Wilson
chris at chris-wilson.co.uk
Fri Jun 3 14:37:07 UTC 2016
During suspend (or module unload), if we have never accessed the engine
(i.e. userspace never submitted a batch to it), the engine is idle. Then
we attempt to idle the engine by forcing it to the default context,
which actually means we submit a render batch to setup the golden
context state and then wait for it to complete. We can skip this
entirely as we know the engine is idle.
v2: Drop incorrect comment.
References: https://bugs.freedesktop.org/show_bug.cgi?id=95634
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 343d88114f3b..b0dda0433347 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3429,8 +3429,10 @@ int i915_gpu_idle(struct drm_device *dev)
struct intel_engine_cs *engine;
int ret;
- /* Flush everything onto the inactive list. */
for_each_engine(engine, dev_priv) {
+ if (engine->last_context == NULL)
+ continue;
+
if (!i915.enable_execlists) {
struct drm_i915_gem_request *req;
--
2.8.1
More information about the Intel-gfx
mailing list