[Intel-gfx] [PATCH 13/24] drm/i915/kbl: Add WaDisableDynamicCreditSharing

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Jun 6 12:56:31 UTC 2016


Matthew Auld <matthew.william.auld at gmail.com> writes:

> [ text/plain ]
>> +       /* WaDisableDynamicCreditSharing:kbl */
>> +       if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0))
>> +               WA_SET_BIT(GAMT_CHKN_BIT_REG, (1 << 28));
>> +
> Let's play name that bit!
>
> Otherwise the patch looks good, although slightly worrying that the
> hsd's state the WA is needed up to B0, but the WA db says up to A0...
>
> I guess we should rather trust the hsd's?

Yes I consider hsd's the authoritative source.

-Mika



>
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-gfx mailing list