[Intel-gfx] [PATCH 2/2] drm/i915: Crop cursor image for CHV pipe C cursor issue

Daniel Vetter daniel at ffwll.ch
Thu Jun 9 17:03:17 UTC 2016


On Wed, Jun 8, 2016 at 12:18 PM, Dave Gordon <david.s.gordon at intel.com> wrote:
> On 08/06/16 09:40, Daniel Vetter wrote:
>>
>> On Wed, Jun 08, 2016 at 01:57:44PM +0530, Akshu Agrawal wrote:
>>>
>>> CHV pipe C hits underrun when we get -ve X values of cursor. To avoid
>>> this we crop the cursor image for by -ve X value and thus use '0' as
>>> least X value.
>>
>>
>> You're talking about "-ve" here and there's absolutely no "-ve" anywhere
>> in your patch. That makes your commit message non-understandable.
>
>
> That's shorthand for "negative", and some of the code below is indeed
> testing for a negative X coordinate, e.g:

Just type it out, thanks. Not everyone is a native speaker and knows
all this stuff.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list