[Intel-gfx] [PATCH v3] drm/i915/opregion: update cadl based on actually active outputs
Maarten Lankhorst
maarten.lankhorst at linux.intel.com
Mon Jun 13 10:21:53 UTC 2016
Op 13-06-16 om 12:00 schreef Jani Nikula:
> Previously we've just shoved the first eight devices in DIDL to CADL
> (list of active outputs). Some of the active outputs may have been left
> outside of CADL. The problem is, some BIOS implementations prevent
> laptop brightness hotkey propagation if the flat panel is not active.
>
> Now that we have connector to acpi device id mapping covered, we can
> update CADL based on which outputs are actually active.
>
> v3: actually git add the dev->dev_priv change.
>
Can CADL be set before the crtc's are updated?
It seems to me it should be set after intel_shared_dpll_commit,
since that's when we update all sw state. And put behind a if (intel_state->modeset),
it's not allowed to walk the connector list otherwise. We get away with it now
because we always take mode_config.mutex.
More information about the Intel-gfx
mailing list