[Intel-gfx] [PATCH 03/14] drm: Link directly from drm_master to drm_device

Emil Velikov emil.l.velikov at gmail.com
Wed Jun 15 12:50:02 UTC 2016


On 14 June 2016 at 19:50, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Master-based auth only exists for the legacy/primary drm_minor, hence
> there can only be one per device. The goal here is to untangle the
> epic dereference games of minor->master and master->minor which is
> just massively confusing.
>
Good riddance :-)
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Taking this a step further, have you considered:
 - having the master under drm_device, then
 - nuking the drm_file/drm_minor one and adding drm_minor::has_master.
The last one will be checked before accessing drm_minor::dev::master.

The above should work just fine, right ?

-Emil


More information about the Intel-gfx mailing list