[Intel-gfx] [PATCH 15/44] drm/i915: Make panel/backlight safe to setup/cleanup multiple times

[Chris Wilson]

On Thu, Jun 16, 2016 at 09:34:05AM +0300, Jani Nikula wrote:
> On Wed, 15 Jun 2016, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Allow everyone to call intel_panel_setup_backlight() (i.e. only take
> > effect if we have previously been initialised for use as a panel) and,
> > for paranoia, allow intel_panel_cleanup_backlight() to be called
> > multiple times.
> 
> Maybe I'm dumb or blind or both, but I don't see why this patch is
> needed, even in light of the following patches. Please enlighten me.

It was for having symmetric intel_panel_setup_backlight() and
intel_panel_destroy_backlight(), as they called from asymmetric code
paths currently.

Since Ville asked to keep the asymmetry, this can be dropped if you see
no other merit to having the embedded struct marked as being initialised.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre