[Intel-gfx] [PATCH v2 10/15] drm/i915: Extending i915_gem_check_wedge to check engine reset in progress

Chris Wilson chris at chris-wilson.co.uk
Fri Jun 17 07:41:27 UTC 2016


On Fri, Jun 17, 2016 at 08:09:10AM +0100, Arun Siluvery wrote:
> @@ -1515,6 +1541,13 @@ int __i915_wait_request(struct drm_i915_gem_request *req,
>  			break;
>  		}
>  
> +		reset_pending = i915_engine_reset_pending(&dev_priv->gpu_error,
> +							  NULL);
> +		if (reset_pending) {
> +			ret = -EAGAIN;

You haven't prepared all call paths to handle the error.
Tell me again what you need struct_mutex for?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list