[Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

[Emil Velikov]

Hi Rob,

A couple of nitpicks and a case of missing git add :-)

On 15 June 2016 at 10:51,  <robert.foss at collabora.com> wrote:

> +if HAVE_LIBDRM_INTEL
> +else
> +    libintel_tools_la_SOURCES +=       \
> +        stubs/drm/intel_bufmgr.c       \
> +        stubs/drm/intel_bufmgr.h
> +endif
> +
I believe I mentioned if before - please use the following construct

if !HAVE_LIBDRM_INTEL
    libintel_tools_la_SOURCES +=       \
        stubs/drm/intel_bufmgr.c       \
        stubs/drm/intel_bufmgr.h
endif

>  AM_CPPFLAGS = -I$(top_srcdir)
>  AM_CFLAGS = $(CWARNFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(LIBUNWIND_CFLAGS) $(DEBUG_CFLAGS) \
>             -DIGT_SRCDIR=\""$(abs_top_srcdir)/tests"\" \
> diff --git a/lib/stubs/drm/README b/lib/stubs/drm/README
> new file mode 100644
> index 0000000..dec6a1d
> --- /dev/null
> +++ b/lib/stubs/drm/README
> @@ -0,0 +1,4 @@
> +intel_bufmgr.h is a copy the file provided in libdrm (intel/intel_bufmgr.h).
> +
s/copy the file provided in/local copy of the file provided by/

Sadly that's not the case atm. There's a fair few changes in the local 'copy'.
Perhaps you forgot to git add ?

> +Before releasing i-g-t a current copy of intel_bufmgr.h should be copied into
> +this directory of i-g-t.

Thinking about it... I'm not sure that the release manager will find
this note here :-\

Daniel V, Marius, do you guys have a tick-off list somewhere where
this could be added ?

Regards,
Emil