[Intel-gfx] [PATCH i-g-t] assembler/: Fix lex warnings for %empty and %nonassoc.

[Marius Vlad]

Thanks for the tip. I haven't noticed any differences in the generated
output, so I've applied it.

On Thu, May 19, 2016 at 03:07:46PM +0100, Damien Lespiau wrote:
> On Thu, May 19, 2016 at 07:02:40AM -0700, Ben Widawsky wrote:
> > On Thu, May 19, 2016 at 12:28:10PM +0100, Damien Lespiau wrote:
> > > On Mon, May 16, 2016 at 01:39:10PM +0300, Marius Vlad wrote:
> > > > Signed-off-by: Marius Vlad <marius.c.vlad at intel.com>
> > > > ---
> > > >  assembler/gram.y | 74 ++++++++++++++++++++++++++++----------------------------
> > > >  1 file changed, 37 insertions(+), 37 deletions(-)
> > > 
> > > The only way to test the change is to regenerate the vaapi shaders from
> > > source and check for differences in the generated opcodes.
> >
> > Didn't we have something like this in the test/ directory?
> 
> We have just a few unmaintained tests that don't pass (or do they?) and
> they barely scratch the surface of what would be needed to decent
> coverage.

They do pass, but wasn't sure if they are sufficient.

> 
> vaapi-driver is a much better test suite.
> 
> -- 
> Damien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20160623/c7cd7d07/attachment.sig>