[Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

Lim, Siew Hoon siew.hoon.lim at intel.com
Tue Mar 1 10:33:12 UTC 2016

> On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote:
> > The assert check for c->bo should be done before DBG, else it will hit
> > memory access violation when c->bo is null.
> >
> > Signed-off-by: Lim Siew Hoon <siew.hoon.lim at intel.com>
> > Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
> Pardon? With a r-b?

What is a r-b? 
I'm helping to fix the KW issue hit in our repo side. 
I suggest the assert checking should be move up before DBG(...) print statement to avoid memory access violation happen if c->bo is NULL for print message. 
Of cause the chance will be very low to get c->bo is NULL.  


> -Chris
> --
> Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list