[Intel-gfx] [PATCH] sna: move up the assert check before DBG print message
Lim, Siew Hoon
siew.hoon.lim at intel.com
Tue Mar 1 12:22:25 UTC 2016
> On Tue, Mar 01, 2016 at 10:33:12AM +0000, Lim, Siew Hoon wrote:
> > >
> > > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote:
> > > > The assert check for c->bo should be done before DBG, else it will
> > > > hit memory access violation when c->bo is null.
> > > >
> > > > Signed-off-by: Lim Siew Hoon <siew.hoon.lim at intel.com>
> > > > Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
> > >
> > > Pardon? With a r-b?
> > What is a r-b?
ohh....sorry about this. It should another 1 lines signed-off-by after Reviewed-by.
> > I'm helping to fix the KW issue hit in our repo side.
> There is no bug in the code, just kw. It is a ternary operator guarding the
> > I suggest the assert checking should be move up before DBG(...) print
> statement to avoid memory access violation happen if c->bo is NULL for print
> > Of cause the chance will be very low to get c->bo is NULL.
> If you look at the code if prints handle=0 if c->bo to indicate the NULL. Please
> read the code first.
Oh...ok. And you are right. Thank you for feedback.
> Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx