[Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 3 11:45:37 UTC 2016


On Thu, Mar 03, 2016 at 11:27:47AM +0000, Auld, Matthew wrote:
> > Handle overflow?
> 
> Okay, good idea.
> 
> > Why do it here and not at creation?
> 
> We could, given that we currently only exercise partial views in the gem fault handler code, but as Joonas mentioned we are expecting further use of partial views, so it makes sense to have the check in only one place.

More use of broken code? Please review the patches to fix the current
implementation first!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list