[Intel-gfx] [PATCH 2/5] drm/i915/lrc: Do not wait atomically when stopping engines
Tvrtko Ursulin
tvrtko.ursulin at linux.intel.com
Thu Mar 3 14:36:42 UTC 2016
From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
I do not see that this needs to be done atomically and up to
one second is quite a long time to busy loop.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 4f19ca7490c4..a59e0537c251 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1063,7 +1063,7 @@ void intel_logical_ring_stop(struct intel_engine_cs *ring)
/* TODO: Is this correct with Execlists enabled? */
I915_WRITE_MODE(ring, _MASKED_BIT_ENABLE(STOP_RING));
- if (wait_for_atomic((I915_READ_MODE(ring) & MODE_IDLE) != 0, 1000)) {
+ if (wait_for((I915_READ_MODE(ring) & MODE_IDLE) != 0, 1000)) {
DRM_ERROR("%s :timed out trying to stop ring\n", ring->name);
return;
}
--
1.9.1
More information about the Intel-gfx
mailing list