[Intel-gfx] [PATCH 044/190] drm/i915: Move GEM request routines to i915_gem_request.c

[Tvrtko Ursulin]

On 25/02/16 17:52, Arun Siluvery wrote:
> On 11/01/2016 09:16, Chris Wilson wrote:
>> Migrate the request operations out of the main body of i915_gem.c and
>> into their own C file for easier expansion.
>>
>> v2: Move __i915_add_request() across as well
>>
>> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> ---
>
> don't we lose the history in git blame when moved to a new file? is this
> ok? especially for files like i915_gem.c.

Could git blame -C be the answer to this downside? If it works as 
advertised:

"""
        -C|<num>|
            In addition to -M, detect lines moved or copied from other 
files that were modified in the same commit. This is useful when you 
reorganize your program and move code around across files. When this 
option is given
            twice, the command additionally looks for copies from other 
files in the commit that creates the file. When this option is given 
three times, the command additionally looks for copies from other files 
in any
            commit.
"""

I think there would be value in separating the request bits from the 
memory management bits. It is easier to work with smaller files, 
especially when they are logically organised.

So ack on this from me.

Regards,

Tvrtko