[Intel-gfx] [PATCH 11/16] drm/i915: Compute DSI PLL parameters during .compute_config()

[Jani Nikula]

On Tue, 15 Mar 2016, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Compute the DSI PLL parameters during .compute_config() rather than
> .pre_pll_enable() so that we can fail gracefully if we can't find
> suitable parameters.
>
> In order to do that we need to store the DSI PLL parameters in
> pipe_config.
>
> v2: Handle BXT too
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

[snip]

> @@ -317,15 +328,9 @@ static u32 bxt_dsi_get_pclk(struct intel_encoder *encoder, int pipe_bpp)
>  		return 0;
>  	}
>  
> -	dsi_ratio = I915_READ(BXT_DSI_PLL_CTL) &
> -				BXT_DSI_PLL_RATIO_MASK;
> +	config->dsi_pll.ctrl = I915_READ(BXT_DSI_PLL_CTL);
>  
> -	/* Invalid DSI ratio ? */
> -	if (dsi_ratio < BXT_DSI_PLL_RATIO_MIN ||
> -			dsi_ratio > BXT_DSI_PLL_RATIO_MAX) {
> -		DRM_ERROR("Invalid DSI pll ratio(%u) programmed\n", dsi_ratio);
> -		return 0;
> -	}

So you expect this to show up in the state checker instead now?

Reviewed-by: Jani Nikula <jani.nikula at intel.com>



-- 
Jani Nikula, Intel Open Source Technology Center