[Intel-gfx] [PATCH i-g-t] intel: Adding missing Broxton PCI IDs.

Vivi, Rodrigo rodrigo.vivi at intel.com
Fri Mar 18 16:32:54 UTC 2016


On Fri, 2016-03-18 at 00:42 +0000, Arun Siluvery wrote:
> On 17/03/2016 21:39, Rodrigo Vivi wrote:
> > These IDs were already part of the kernel since:
> > 
> > kernel commit 985dd4360fdf2533fe48a33a4a2094f2e4718dc0
> > Author: Imre Deak <imre.deak at intel.com>
> > Date:   Thu Jan 28 16:04:12 2016 +0200
> > 
> >       drm/i915/bxt: update list of PCIIDs
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > ---
> >   lib/intel_chipset.h | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> > index f3bd04f..4b40612 100644
> > --- a/lib/intel_chipset.h
> > +++ b/lib/intel_chipset.h
> > @@ -236,6 +236,8 @@ void intel_check_pch(void);
> >   #define PCI_CHIP_BROXTON_0		0x0A84
> >   #define PCI_CHIP_BROXTON_1		0x1A84
> >   #define PCI_CHIP_BROXTON_2		0x5A84
> > +#define PCI_CHIP_BROXTON_3		0x1A85
> > +#define PCI_CHIP_BROXTON_4		0x5A85
> > 
> >   #endif /* __GTK_DOC_IGNORE__ */
> > 
> > @@ -460,7 +462,9 @@ void intel_check_pch(void);
> > 
> >   #define IS_BROXTON(devid)	((devid) == PCI_CHIP_BROXTON_0
> > || \
> >   				 (devid) == PCI_CHIP_BROXTON_1 ||
> > \
> > -				 (devid) == PCI_CHIP_BROXTON_2)
> > +				 (devid) == PCI_CHIP_BROXTON_2 ||
> > \
> > +				 (devid) == PCI_CHIP_BROXTON_3 ||
> > \
> > +				 (devid) == PCI_CHIP_BROXTON_4)
> > 
> >   #define IS_GEN9(devid)		(IS_KABYLAKE(devid) || \
> >   				 IS_SKYLAKE(devid) || \
> > 
> I have recently added them to libdrm in android, would you also be 
> adding them to libdrm?

I did libdrm one 2 weeks ago. It was reviewed and merged already.

> 
> looks good to me,
> Reviewed-by: Arun Siluvery <arun.siluvery at linux.intel.com>

Thanks for the review. Patch merged.

> 
> regards
> Arun
> 


More information about the Intel-gfx mailing list