[Intel-gfx] [PATCH 1/3] drm/i915/gtt: Reference mappable_end variable from pointer

Daniel Vetter daniel at ffwll.ch
Mon Mar 21 09:41:52 UTC 2016


On Mon, Mar 21, 2016 at 09:39:04AM +0000, Chris Wilson wrote:
> On Mon, Mar 21, 2016 at 10:35:08AM +0100, Daniel Vetter wrote:
> > On Fri, Mar 18, 2016 at 10:54:03AM +0200, Joonas Lahtinen wrote:
> > > On pe, 2016-03-18 at 08:21 +0000, Chris Wilson wrote:
> > > > On Fri, Mar 18, 2016 at 09:53:08AM +0200, Joonas Lahtinen wrote:
> > > > > 
> > > > > Reference variable value from pointer, not assumed pointer destination.
> > > > > 
> > > > > Since:
> > > > > 
> > > > > commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9
> > > > > Author: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > > > > Date:   Thu Jun 25 18:35:05 2015 +0300
> > > > > 
> > > > >     drm/i915/gtt: Allow >= 4GB sizes for vm.
> > > > > 
> > > > > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > > > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > > 
> > > > That reminds, could you pull
> > > > 
> > > > https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=breadcrumbs&id=8ecc77b5864d4911e9fb9b92be8b2e98c3f2261f
> > > > [drm/i915: Codify our assumption that the Global GTT is <= 4GiB]
> > > > 
> > > > into this series?
> > > 
> > > Done, sent series v2 with one typo fix and that patch rebased (and
> > > tweaked 1ull -> 1ULL).
> > > 
> > > So if somebody would review the new patch, we're good to merge.
> > 
> > Patch is wrong Chris, you can review it, and then push the entire pile
> 
> Which patch? The only one outstanding is my suggestion to add the WARN.

s/wrong/from/ ... I can't type :( And yeah I missed that it landed already
;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list