[Intel-gfx] [PATCH 3/4] drm/i915: opt-out CPU and WC mmaps from FBC

Jani Nikula jani.nikula at linux.intel.com
Tue Mar 22 10:28:20 UTC 2016


On Mon, 21 Mar 2016, Paulo Zanoni <paulo.r.zanoni at intel.com> wrote:
> +enum fb_mmap_wa_flags {
> +	FB_MMAP_WA_CPU =	1 << 0,
> +	FB_MMAP_WA_GTT =	1 << 1,
> +	FB_MMAP_WA_DISABLE = 	1 << 2,
> +	FB_MMAP_WA_FLAG_COUNT =	3,
> +};

Drive-by review, adding bit flags as enums doesn't feel like what enums
should be used for. I'd go for macros instead.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list