[Intel-gfx] [PATCH] drm/i915: Reject non-canonical rotations

Matthew Auld matthew.william.auld at gmail.com
Tue Mar 22 14:14:38 UTC 2016

Hi Daniel,

>> I thought we do normalize this somewhere.

I did write an i-g-t test which submits such a rotation value and it
is not rejected.

>> Your patch lacks motivation

As in I haven't properly conveyed the motivation behind the patch in
the commit message?

>> Yes I can usually guess when
it's due to static analyzer checks, but you need to explain that. And you
need to explain what exactly the analyzer is complaining about.

erm, no static analyser, for this patch or any prior, promise, but duly noted ;)

Joonas actually suggested this patch, and some of the preceding ones
as beginner tasks for me.


More information about the Intel-gfx mailing list