[Intel-gfx] [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.

[Dylan Baker]

Quoting Vivi, Rodrigo (2016-03-21 19:00:10)
> On Mon, 2016-03-21 at 12:53 +0200, Marius Vlad wrote:
> > Isn't this as https://patchwork.freedesktop.org/series/4177/?
> > 
> > On Fri, Mar 18, 2016 at 07:02:11AM -0700, Rodrigo Vivi wrote:
> > > The following piglit commit adds one option to overwrite files:
> > > 
> > > commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
> > > Author: Dylan Baker <baker.dylan.c at gmail.com>
> > > Date:   Mon Feb 1 15:08:23 2016 -0800
> > > 
> > >     framework/programs/run.py: Add option for overwriting files
> > > 
> > > So our run-script.sh test that creates the directory before
> > > executing
> > > the tests were failing with:
> > > 
> > > "Fatal Error: Cannot overwrite existing folder w/o the -o /-
> > > -overwrite option being sent"
> > > 
> > > I believe it took a while to notice that because many of us never
> > > upgrade the piglit. But also the risk with this patch is to have an
> > > environment
> > > with the old piglit so the result will be:
> > > piglit: error: unrecognized arguments: --overwrite
> > 
> > Maybe we can test against piglit version and use it accordingly.
> 
> Yeah, I wondered that... but apparently piglit doesn't return the
> version...
> The ugly way that came to my mind was something like:
> 
> $PIGLIT run --help | grep overwrite > /dev/null
> if [ $? -eq 0 ]; then
>  # use overwwrite
> else
>  # keep the old
> fi
> 
> any non-ugly idea?
> 

I was just thinking that it was stupid that piglit doesn't have a
version of any kind. I'm planning to add one although it will only be a
git sha and maybe a date since piglit intentionally doesn't have major
or minor version numbers.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20160322/a6207993/attachment.sig>