[Intel-gfx] [RFC] drm/i915: Move execlists irq handler to a bottom half

[Tvrtko Ursulin]

On 23/03/16 15:23, Tvrtko Ursulin wrote:
>
> On 23/03/16 12:56, Chris Wilson wrote:
>> On Wed, Mar 23, 2016 at 12:46:35PM +0000, Tvrtko Ursulin wrote:
>>>
>>> On 23/03/16 11:31, Chris Wilson wrote:
>>>> On Wed, Mar 23, 2016 at 10:08:46AM +0000, Tvrtko Ursulin wrote:
>>>>> You think it is OK to continue sharing your one,
>>>>> https://bugs.freedesktop.org/show_bug.cgi?id=93467?
>>>>
>>>> Yes, it fixes the same freeze (and we've removed the loop from chv irq
>>>> so there really shouldn't be any others left!)
>>>
>>> I don't see that has been merged. Is it all ready CI wise so we could?
>>
>> On the CI ping:
>> id:20160314103014.30028.12472 at emeril.freedesktop.org
>>
>> == Summary ==
>>
>> Series 4298v3 drm/i915: Exit cherryview_irq_handler() after one pass
>> http://patchwork.freedesktop.org/api/1.0/series/4298/revisions/3/mbox/
>>
>> Test drv_module_reload_basic:
>>                  pass       -> SKIP       (skl-i5k-2)
>>                  pass       -> INCOMPLETE (bsw-nuc-2)
>> Test gem_ringfill:
>>          Subgroup basic-default-s3:
>>                  dmesg-warn -> PASS       (bsw-nuc-2)
>> Test gem_tiled_pread_basic:
>>                  incomplete -> PASS       (byt-nuc)
>> Test kms_flip:
>>          Subgroup basic-flip-vs-dpms:
>>                  dmesg-warn -> PASS       (bdw-ultra)
>>          Subgroup basic-flip-vs-modeset:
>>                  incomplete -> PASS       (bsw-nuc-2)
>> Test kms_pipe_crc_basic:
>>          Subgroup suspend-read-crc-pipe-a:
>>                  incomplete -> PASS       (hsw-gt2)
>> Test pm_rpm:
>>          Subgroup basic-pci-d3-state:
>>                  dmesg-warn -> PASS       (bsw-nuc-2)
>>
>> bdw-nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0
>> skip:12
>> bdw-ultra        total:194  pass:173  dwarn:0   dfail:0   fail:0
>> skip:21
>> bsw-nuc-2        total:189  pass:151  dwarn:0   dfail:0   fail:0
>> skip:37
>> byt-nuc          total:194  pass:154  dwarn:4   dfail:0   fail:1
>> skip:35
>> hsw-brixbox      total:194  pass:172  dwarn:0   dfail:0   fail:0
>> skip:22
>> hsw-gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0
>> skip:17
>> ivb-t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0
>> skip:25
>> skl-i5k-2        total:194  pass:170  dwarn:0   dfail:0   fail:0
>> skip:24
>> skl-i7k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0
>> skip:23
>> snb-dellxps      total:194  pass:159  dwarn:1   dfail:0   fail:0
>> skip:34
>> snb-x220t        total:194  pass:159  dwarn:1   dfail:0   fail:1
>> skip:33
>>
>> Results at /archive/results/CI_IGT_test/Patchwork_1589/
>>
>> 3e5ecc8c5ff80cb1fb635ce1cf16b7cd4cfb1979 drm-intel-nightly:
>> 2016y-03m-14d-09h-06m-00s UTC integration manifest
>> 7928c2133b16eb2f26866ca05d1cb7bb6d41c765 drm/i915: Exit
>> cherryview_irq_handler() after one pass
>>
>> ==
>>
>> drv_module_reload_basic is weird, but it appears the hiccup CI had on the
>> previous run were external (and affected several CI runs afaict).
>
> That part is goog then, but I am not sure what to do with the incomplete
> run. Maybe have it do another one? Although that is quite weak. Problem
> is it has no other hangs with that test in the history.

goog yes :) I got a bsw-nuc2 hang in results yesterday for a series 
which I don't think could really have caused it. So I think there might 
be something really wrong either with that machine or with the driver 
reload on chv/bsw in general.

Regards,

Tvrtko