[Intel-gfx] [PATCH v2 1/5] drm: add picture aspect ratio flags

[Sharma, Shashank]

Ok, will do it for other patches too.

Regards
Shashank
-----Original Message-----
From: Jani Nikula [mailto:jani.nikula at linux.intel.com] 
Sent: Thursday, March 24, 2016 6:26 PM
To: Sharma, Shashank; Vivi, Rodrigo
Cc: intel-gfx at lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 1/5] drm: add picture aspect ratio flags

On Thu, 24 Mar 2016, Shashank Sharma <shashank.sharma at intel.com> wrote:
> This patch adds drm flag bits for aspect ratio information
>
> Currently drm flag bits don't have field for mode's picture aspect 
> ratio. This field will help the driver to pick mode with right aspect 
> ratio, and help in setting right VIC field in avi infoframes.
>
> Signed-off-by: Shashank Sharma <shashank.sharma at intel.com>
> ---
>  include/uapi/drm/drm_mode.h | 18 +++++++++++++-----

Please use scripts/get_maintainer.pl on the patch to figure out who it should be sent to. This file is not maintained by us, so we can't just merge it.

For example:

$ scripts/get_maintainer.pl 0001-drm-add-picture-aspect-ratio-flags.patch
David Airlie <airlied at linux.ie> (maintainer:DRM DRIVERS) dri-devel at lists.freedesktop.org (open list:DRM DRIVERS) linux-kernel at vger.kernel.org (open list)

Of course, since you ultimately aim for a change in drm/i915, you should also Cc: intel-gfx.

BR,
Jani.


>  1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h 
> index 50adb46..3389bd1 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -73,6 +73,19 @@
>  #define  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM	(7<<14)
>  #define  DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF	(8<<14)
>  
> +/* Picture aspect ratio options */
> +#define DRM_MODE_PICTURE_ASPECT_NONE		0
> +#define DRM_MODE_PICTURE_ASPECT_4_3		1
> +#define DRM_MODE_PICTURE_ASPECT_16_9		2
> +
> +/* Aspect ratio flag bitmask (4 bits 21:19) */
> +#define	 DRM_MODE_FLAG_PARMASK		(0x0F<<19)
> +#define  DRM_MODE_FLAG_PARNONE \
> +		(DRM_MODE_PICTURE_ASPECT_NONE << 19) #define  DRM_MODE_FLAG_PAR4_3 
> +\
> +		(DRM_MODE_PICTURE_ASPECT_4_3 << 19) #define  DRM_MODE_FLAG_PAR16_9 
> +\
> +		(DRM_MODE_PICTURE_ASPECT_16_9 << 19)
>  
>  /* DPMS flags */
>  /* bit compatible with the xorg definitions. */ @@ -88,11 +101,6 @@
>  #define DRM_MODE_SCALE_CENTER		2 /* Centered, no scaling */
>  #define DRM_MODE_SCALE_ASPECT		3 /* Full screen, preserve aspect */
>  
> -/* Picture aspect ratio options */
> -#define DRM_MODE_PICTURE_ASPECT_NONE	0
> -#define DRM_MODE_PICTURE_ASPECT_4_3	1
> -#define DRM_MODE_PICTURE_ASPECT_16_9	2
> -
>  /* Dithering mode options */
>  #define DRM_MODE_DITHERING_OFF	0
>  #define DRM_MODE_DITHERING_ON	1

--
Jani Nikula, Intel Open Source Technology Center