[Intel-gfx] [PATCH v2] drm/i915: Rename GGTT init functions

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Mar 30 10:54:39 UTC 2016


On ke, 2016-03-30 at 10:12 +0100, Chris Wilson wrote:
> On Tue, Mar 29, 2016 at 03:25:38PM +0100, Chris Wilson wrote:
> > 
> > On Tue, Mar 29, 2016 at 04:15:54PM +0300, Joonas Lahtinen wrote:
> > > 
> > > On to, 2016-03-24 at 16:47 +0200, Joonas Lahtinen wrote:
> > > > 
> > > > Rename and document the GGTT init functions to give a better
> > > > idea of the context where they are called from.
> > > > 
> > > > i915_gem_gtt_init => i915_ggtt_init_hw
> > > > i915_gem_init_global_gtt => i915_gem_init_ggtt
> > > > i915_global_gtt_cleanup => i915_ggtt_cleanup_hw
> > > > 
> > > > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > > > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > > > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > > Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Chris, accidentally did not remove you A-b for v2. You can retake your
> > > position here.
> > > 
> > > This is the best balance between general naming logic and consistency
> > > with ppgtt I could come up. How about I merge this?
> > I don't have any better names to suggest, and the init_hw should help a
> > lot. Go for it.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Merged, thanks for review and comments everyone.

> -Chris
> 
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list