[Intel-gfx] [PATCH v4] drm/i915: Refer to GGTT {, VM} consistently

Chris Wilson chris at chris-wilson.co.uk
Wed Mar 30 14:17:19 UTC 2016

On Wed, Mar 30, 2016 at 04:57:10PM +0300, Joonas Lahtinen wrote:
> Refer to the GGTT VM consistently as "ggtt->base" instead of just "ggtt",
> "vm" or indirectly through other variables like "dev_priv->ggtt.base"
> to avoid confusion with the i915_ggtt object itself and PPGTT VMs.
> Refer to the GGTT as "ggtt" instead of indirectly through chaining.
> As a bonus gets rid of the long-standing i915_obj_to_ggtt vs.
> i915_gem_obj_to_ggtt conflict, due to removal of i915_obj_to_ggtt!
> v2:
> - Added some more after grepping sources with Chris
> v3:
> - Refer to GGTT VM through ggtt->base consistently instead of ggtt_vm (Chris)
> v4:
> - Convert all dev_priv->ggtt->foo accesses to ggtt->foo.
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

It pains me to see changes to code I've deleted, but nevertheless the
consistency looks good.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list