[Intel-gfx] [PATCH 1/2] drm/i915: Use i915_vm_to_ppgtt instead of manual container_of

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 31 17:10:20 UTC 2016


On Thu, Mar 31, 2016 at 07:49:38PM +0300, Joonas Lahtinen wrote:
> As we have the function with error checking, use it.

However, that error checking turns up in the profiles for some GL
benchmarks. Crazy huh!

Note also that you missed an opportunity in
i915_gem_restore_gtt_mappins()

Please let's just treat the programmer with a little respect here.

If you kindly remove the WARN, then
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list