[Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

[Daniel Vetter]

On Thu, Apr 28, 2016 at 11:57:21AM -0400, Robert Foss wrote:
> 
> 
> On 04/28/2016 10:41 AM, Daniel Vetter wrote:
> >On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote:
> >>
> >>
> >>On 04/28/2016 04:02 AM, Daniel Vetter wrote:
> >>>On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
> >>>>
> >>>>
> >>>>On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
> >>>>>On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
> >>>>>>
> >>>>>>
> >>>>>>On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> >>>>>>>On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss at collabora.com wrote:
> >>>>>>>>From: Robert Foss <robert.foss at collabora.com>
> >>>>>>>>
> >>>>>>>>Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> >>>>>>>>connectors.
> >>>>>>>>
> >>>>>>>>Signed-off-by: Robert Foss <robert.foss at collabora.com>
> >>>>>>>>---
> >>>>>>>>   tests/kms_panel_fitting.c | 12 +++++++++---
> >>>>>>>>   1 file changed, 9 insertions(+), 3 deletions(-)
> >>>>>>>>
> >>>>>>>>diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >>>>>>>>index 60a22b0..933776c 100644
> >>>>>>>>--- a/tests/kms_panel_fitting.c
> >>>>>>>>+++ b/tests/kms_panel_fitting.c
> >>>>>>>>@@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> >>>>>>>>   	for_each_connected_output(display, output) {
> >>>>>>>>   		drmModeModeInfo *mode, native_mode;
> >>>>>>>>
> >>>>>>>>-		if (output->config.connector->connector_type !=
> >>>>>>>>-			DRM_MODE_CONNECTOR_eDP)
> >>>>>>>>-			continue;
> >>>>>>>>+		switch (output->config.connector->connector_type)
> >>>>>>>>+		{
> >>>>>>>>+		    case DRM_MODE_CONNECTOR_LVDS:
> >>>>>>>>+		    case DRM_MODE_CONNECTOR_eDP:
> >>>>>>>>+		    case DRM_MODE_CONNECTOR_DSI:
> >>>>>>>>+			    break;
> >>>>>>>>+		    default:
> >>>>>>>>+			    continue;
> >>>>>>>>+		}
> >>>>>>>
> >>>>>>>I think ville commented that we should instead check for "scaling mode",
> >>>>>>>and we discussed this on irc. Am I accidentally looking at an old patch
> >>>>>>>series?
> >>>>>>>-Daniel
> >>>>>>>
> >>>>>>No, this isn't an old patch, I misunderstood where our conversation ended.
> >>>>>>
> >>>>>>"scaling mode" is an intel specific extension as far as I understand it,
> >>>>>>which is somewhat the opposite of generalizing i-g-t tests.
> >>>>>>
> >>>>>>Is there an architecture independent way forward?
> >>>>>
> >>>>>A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
> >>>>>i915, nouveau, and radeon. Seems fairly independent to me.
> >>>>>
> >>>>If that is the case, and it seems to be, "scaling mode" is definitely
> >>>>worth pursuing.
> >>>
> >>>Perhaps also send in a kernel patch to update the docbook table? It's
> >>>awful, but the best thing we have right now ...
> >>>-Daniel
> >>>
> >>
> >>Other than a Description/Restrictions entry for "scaling mode", is there
> >>anything you'd like to see added?
> >
> >I meant moving it into the generic section and list which drivers support
> >it. No need to change the description itself - that's an entire project on
> >itself.
> >-Daniel
> >
> 
> I'm not seeing any other properties that have driver support listed. Would
> adding a column called "Driver support" make sense?

Not sure we want to go to all that trouble. The current table is pretty
much a dead-end wrt documentation, and we're just stalling on getting
better markup support for kerneldoc before we can fix it all up properly.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch