[Intel-gfx] [PATCH] drm/i915: add missing condition for committing planes on crtc

Lionel Landwerlin lionel.g.landwerlin at intel.com
Wed May 4 10:25:12 UTC 2016


On 21/04/16 14:57, Ville Syrjälä wrote:
> On Thu, Apr 21, 2016 at 03:30:09PM +0200, Maarten Lankhorst wrote:
>> Hey,
>>
>> Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
>>> Ping?
>>>
>> Will commit, but looks like Ville made a comment about double buffering.
>>
>> Everything in intel_pipe_update_start depends on double buffering, so if the lut isn't then it probably has to be done either before or afterwards. Not sure which, either way would produce some flickering. :(
> It should be done from a vblank worker. Unfortunately we still don't
> have those, so either before or after is fine, and it'll result in
> exactly the same amount of flickering as the current code.
>
Should I take from this that the patch is fine for now as we don't have 
vblank workers yet?
I can resend another version with a TODO comment.

Thanks,

-
Lionel


More information about the Intel-gfx mailing list