[Intel-gfx] [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks

[Maarten Lankhorst]

Op 29-04-16 om 16:31 schreef ville.syrjala at linux.intel.com:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> When the crtc is enabled but !active, we should still compute the
> watermarks as if the planes were visible. That would make it more
> likely that the we can later transition to active without errors.
>
> Add a FIXME to remind people that we're doing the wrong thing now.
> We should perhaps just move the wm computation for each individual plane
> into the .check_plane hook, and later we'd just combine the results from
> all active planes.
For both patches:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

Not sure how much use there is to calculate watermarks for disabled planes, and then ignore them,
but definitely something to keep in mind.

~Maarten