[Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

Chris Wilson chris at chris-wilson.co.uk
Wed May 4 13:47:17 UTC 2016


On Wed, May 04, 2016 at 02:32:53PM +0100, Peter Antoine wrote:
> Will wait for more comments, then will respin with a different
> commit message. Is the rest of the patch ok?

No, you've put debug information into sysfs. (Also sysfs is one value per
file.) sysfs does not match your goal of validation. And you exported an
internal function (get_mocs...) without giving it a proper name.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list