[Intel-gfx] [PATCH 2/2] drm/i915: Do not use a bitfield for INTEL_INFO->num_pipes
Dave Gordon
david.s.gordon at intel.com
Fri May 6 19:21:28 UTC 2016
On 06/05/16 15:16, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> It just makes more work for the compiler and generates more code.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 935e381407ba..f7a156b8d5a1 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -758,7 +758,7 @@ struct intel_csr {
> struct intel_device_info {
> u32 display_mmio_offset;
> u16 device_id;
> - u8 num_pipes:3;
> + u8 num_pipes;
> u8 num_sprites[I915_MAX_PIPES];
> u8 gen;
> u16 gen_mask;
On my build, this saves 322 bytes, which (since it eliminates just ONE
three-byte instruction on each use), suggests it's used quite a lot!
Reviewed-by: Dave Gordon <david.s.gordon at intel.com>
.Dave.
More information about the Intel-gfx
mailing list