[Intel-gfx] [PATCH] drm/i915: Re-enable GGTT earlier during resume on pre-gen6 platforms

Chris Wilson chris at chris-wilson.co.uk
Fri May 6 20:22:49 UTC 2016


On Fri, May 06, 2016 at 09:35:55PM +0300, ville.syrjala at linux.intel.com wrote:
> @@ -730,9 +730,14 @@ int i915_suspend_switcheroo(struct drm_device *dev, pm_message_t state)
>  static int i915_drm_resume(struct drm_device *dev)
>  {
>  	struct drm_i915_private *dev_priv = dev->dev_private;
> +	int ret;
>  
>  	disable_rpm_wakeref_asserts(dev_priv);
>  
> +	ret = i915_ggtt_enable_hw(dev);
> +	if (ret)
> +		DRM_ERROR("failed to re-enable GGTT\n");

Would it not be fatal for resume as well? Failure means we can't use the
GGTT, so all subsequent writes will be going into a random address.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list