[Intel-gfx] [PATCH] drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

Chris Wilson chris at chris-wilson.co.uk
Mon May 9 16:07:40 UTC 2016


On Mon, May 09, 2016 at 06:59:58PM +0300, Joonas Lahtinen wrote:
> On ma, 2016-05-09 at 14:58 +0100, Chris Wilson wrote:
> > Pass drm_i915_private to the uncore init/fini routines and their
> > subservients as it is their native type.
> > 
> >    text    data     bss     dec     hex filename
> > 6309978 3578778  696320 10585076         a183f4 vmlinux
> > 6309530 3578778  696320 10584628         a18234 vmlinux
> > 
> > a modest 400 bytes of saving, but 60 lines of code deleted!
> 
> Please, do copy & paste the sed command or cocci file to the commit
> message, otherwise looks fine to me.

It was '.'

> I would do this for plenty of
> other functions too and the for the s/dev_priv/i915/. Do you have a
> patch for the preceding s/i915/i915_module/ patch, or should I go and
> write it?

I'm doing them on a case-by-case basis, trying to avoid areas where
people are most likely to conflict. and making an eventual patch to
subclass drm_device trivial (and not grow the code again!)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list