[Intel-gfx] [PATCH 1/4] drm/i915: Add distinct stubs for PM hibernation phases

[Chris Wilson]

On Thu, May 12, 2016 at 02:52:55PM +0300, Imre Deak wrote:
> On Thu, 2016-05-12 at 12:41 +0100, Chris Wilson wrote:
> > Currently for handling the extra hibernation phases we just call the
> > equivalent suspend/resume phases. In the next couple of patches, I wish
> > to specialise the hibernation phases to reduce the amount of work
> > required for handling GEM objects.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak at intel.com>
> > Cc: David Weinehall <david.weinehall at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.c | 34 ++++++++++++++++++++++++++++++----
> >  1 file changed, 30 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 5ae79601335c..4c17e3e8d0ab 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -1115,6 +1115,32 @@ static int i915_pm_resume(struct device *dev)
> >  	return i915_drm_resume(drm_dev);
> >  }
> >  
> > +/* thaw and thaw_early are called after creating the hibernation image,
> > + * but before turning off.
> > + */
> 
> We have these explained for all the phases already around i915_pm_ops.

Yes. I was adding little reminders so that when reading the code for
each phase that information was close to hand.
 
> Also would be good to know if you chose restore over freeze to set the
> object domains. I don't see a practical problem with it, but freeze
> would be a more proper place logically.

Ok, lets have a look at freeze.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre