[Intel-gfx] [PATCH 1/2] drm/i915: Stop retiring requests from busy-ioctl

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri May 13 10:40:12 UTC 2016


Chris Wilson <chris at chris-wilson.co.uk> writes:

> [ text/plain ]
> In order to reduce the workload of the caller, we do not want to
> actually have to retire requests of others when checking the status of
> this object.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gem.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 8439867..474c027 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3069,14 +3069,8 @@ i915_gem_object_flush_active(struct drm_i915_gem_object *obj)
>  		if (req == NULL)
>  			continue;
>  
> -		if (list_empty(&req->list))
> -			goto retire;
> -
> -		if (i915_gem_request_completed(req, true)) {
> -			__i915_gem_request_retire__upto(req);
> -retire:
> +		if (i915_gem_request_completed(req, true))
>  			i915_gem_object_retire__read(obj, i);
> -		}
>  	}
>  
>  	return 0;
> -- 
> 2.8.1


More information about the Intel-gfx mailing list