[Intel-gfx] [PATCH 14/15] drm/i915: Factor out and expose i915_steal_fence()

[Wang, Zhi A]

I see. How about merging this function into i915_find_fence_reg()?

-----Original Message-----
From: Chris Wilson [mailto:chris at chris-wilson.co.uk] 
Sent: Monday, May 16, 2016 7:58 AM
To: Wang, Zhi A <zhi.a.wang at intel.com>
Cc: intel-gfx at lists.freedesktop.org; Gordon, David S <david.s.gordon at intel.com>; joonas.lahtinen at linux.intel.com; Tian, Kevin <kevin.tian at intel.com>; Lv, Zhiyuan <zhiyuan.lv at intel.com>
Subject: Re: [Intel-gfx] [PATCH 14/15] drm/i915: Factor out and expose i915_steal_fence()

On Mon, May 16, 2016 at 01:32:52AM +0800, Zhi Wang wrote:
> Factor out and expose fence stealing functionality for GVT-g. GVT-g 
> will use i915_find_fence_reg() to find a free/unpin fence register and 
> use i915_steal_fence() to steal it.

No. This code cannot be exported as is (the code makes presumptions that the caller will carefully control the reference). And there is nothing to tell us what you need it for.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre