[Intel-gfx] [PATCH 2/7] drm/i915: Use milliseconds in _wait_for macro

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed May 18 11:07:53 UTC 2016


Chris Wilson <chris at chris-wilson.co.uk> writes:

> [ text/plain ]
> On Tue, May 17, 2016 at 06:43:23PM +0300, Mika Kuoppala wrote:
>> Promising 1us accuracy where we timeout using jiffies is
>> misleading. Convert the _wait_for macro to use milliseconds
>> and convert the 2 callsites.
>
> Note this is not about timeout but the the sleep. The timeout here is
> still as inaccurate as ever as it remains jiffie based.
>

Hmm no, the sleep is still in usecs at this stage, unmodified.

-Mika

> (And I have no qualms about the timeout being too high, unless there is
> a specific example that mandates high accuracy.)
> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list