[Intel-gfx] [PATCH i-g-t 1/6] lib/igt_kms: fix clearing up connector/pipe state on atomic commit

Marius Vlad marius.c.vlad at intel.com
Wed May 18 13:44:56 UTC 2016


On Thu, May 12, 2016 at 01:58:07PM +0100, Lionel Landwerlin wrote:
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  lib/igt_kms.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 4da645a..795ecb0 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -2026,9 +2026,8 @@ static void igt_atomic_prepare_crtc_commit(igt_output_t *output, drmModeAtomicRe
>  		igt_atomic_populate_crtc_req(req, output, IGT_CRTC_GAMMA_LUT, pipe_obj->gamma_blob);
>  	}
>  
> -	/*
> -	 *	TODO: Add all crtc level properties here
> -	 */
> +	pipe_obj->background_changed = false;
> +	pipe_obj->color_mgmt_changed = false;
>  }
Just noticed *_changed are defined as uint32_t *_changed : 1. Maybe
change to bool in igt_pipe_t.
>  
>  /*
> @@ -2044,10 +2043,9 @@ static void igt_atomic_prepare_connector_commit(igt_output_t *output, drmModeAto
>  
>  	if (config->connector_dpms_changed)
>  		igt_atomic_populate_connector_req(req, output, IGT_CONNECTOR_DPMS, config->connector_dpms);
> -	/*
> -	 *	TODO: Add all other connector level properties here
> -	 */
>  
> +	config->connector_scaling_mode_changed = false;
> +	config->connector_dpms_changed = false;
>  }
>  
>  /*
> -- 
> 2.8.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20160518/264aaba8/attachment.sig>


More information about the Intel-gfx mailing list