[Intel-gfx] [Nouveau] [PATCH v4] vga_switcheroo: Add helper for deferred probing

Emil Velikov emil.l.velikov at gmail.com
Thu May 19 23:41:04 UTC 2016


Hi Lukas,

On 19 May 2016 at 15:39, Lukas Wunner <lukas at wunner.de> wrote:

> +bool vga_switcheroo_client_probe_defer(struct pci_dev *pdev)
> +{
> +       if ((pdev->class >> 8) == PCI_CLASS_DISPLAY_VGA) {
Not sure if we want/need this, yet at least. This changes behaviour
which is not what refactoring patches should be doing, right ? if
needed it ought to be a separate patch, imho.

Furthermore on nouveau and AMD (iirc) front, some dual-gpu/optimus
systems use PCI_CLASS_DISPLAY_3D. So if we add DISPLAY_VGA perhaps we
should also check for DISPLAY_3D ?

Regards,
Emil


More information about the Intel-gfx mailing list